Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pnpm version upgrade and delete some fixme comments #5638

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

pnpm version upgrade and delete some fixme comments #5638

wants to merge 2 commits into from
+14,483 −10,954

Conversation

necmettindev
Copy link

No description provided.

@necmettindev necmettindev requested review from a team as code owners April 18, 2024 01:19
@vercel Vercel
Copy link

vercel bot commented Apr 18, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
www ❌ Failed (Inspect) Apr 19, 2024 11:46am

@vercel Vercel
Copy link

vercel bot commented Apr 18, 2024

@necmettindev is attempting to deploy a commit to the trpc Team on Vercel.

A member of the Team first needs to authorize it.

@necmettindev necmettindev changed the base branch from main to next April 18, 2024 01:19
@necmettindev necmettindev changed the title pnpm version upgrade and fixme fixes pnpm version upgrade and delete some fixme comments Apr 18, 2024
KATT
KATT requested changes Apr 19, 2024
View reviewed changes
Copy link
Member

@KATT KATT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump pnpm 🙏

Also make sure to allow edits from contributors when you did PRs. I tried to push to your branch but wasn't allowed

.tool-versions Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@KATT KATT mentioned this pull request Apr 19, 2024
Closed
@necmettindev necmettindev reopened this Apr 19, 2024
@juliusmarminge
Copy link
Member

juliusmarminge commented Apr 19, 2024 •
edited

Also make sure to allow edits from contributors when you did PRs. I tried to push toyour branch but wasn't allowed

That's because he opened PR from his next branch. You must branch out from the main branch for maintainers to be able to push. As you can see he hasn't' disabled the option:

CleanShot 2024-04-19 at 14 03 07

@KATT KATT added the ⏳ close if no activity Will be closed if no activity happens within a few weeks label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KATT KATT KATT requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
⏳ close if no activity Will be closed if no activity happens within a few weeks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@necmettindev @juliusmarminge @KATT