Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: init new example #5595

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

chore: init new example #5595

wants to merge 3 commits into from

Conversation

juliusmarminge
Copy link
Member

@juliusmarminge juliusmarminge commented Mar 27, 2024

inits a new next app dir example with just the new caller stuff.

really simple with drizzle sqlite and next auth credentials provider:

CleanShot.2024-03-28.at.00.47.46.mp4

@juliusmarminge juliusmarminge requested a review from a team as a code owner March 27, 2024 23:47
Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-prisma-starter ❌ Failed (Inspect) Mar 27, 2024 11:57pm
og-image ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 11:57pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
www ⬜️ Ignored (Inspect) Visit Preview Mar 27, 2024 11:57pm

Copy link

github-actions bot commented Mar 27, 2024

Diagnostics Comparison

Numbers

Metric PR next
Files 796 795 (🔺 1)
Lines of Library 40,640 40,640 (➖ 0)
Lines of Definitions 118,235 118,080 (🔺 155)
Lines of TypeScript 4,967 4,967 (➖ 0)
Lines of JavaScript 0 0 (➖ 0)
Lines of JSON 0 0 (➖ 0)
Lines of Other 0 0 (➖ 0)
Identifiers 174,958 174,919 (🔺 39)
Symbols 109,030 109,003 (🔺 27)
Types 89 89 (➖ 0)
Instantiations 0 0 (➖ 0)
Memory used 175,948 175,403 (🔺 545)
Assignability cache size 0 0 (➖ 0)
Identity cache size 0 0 (➖ 0)
Subtype cache size 0 0 (➖ 0)
Strict subtype cache size 0 0 (➖ 0)

Timings and averages

Metric PR next
max (s) 4.445 4.483 (🔽🟢 -0.04)
min (s) 4.445 4.483 (🔽🟢 -0.04)
avg (s) 4.445 4.483 (🔽🟢 -0.04)
median (s) 4.445 4.483 (🔽🟢 -0.04)
length 1 1 (➖ 0)
unstable timings

Unstable

Timings are not reliable in here

Metric PR next
I/O Read time 0.04 0.04 (➖ 0)
Parse time 0.73 0.78 (🔽🟢 -0.05)
ResolveTypeReference time 0.03 0.03 (➖ 0)
ResolveModule time 0.11 0.11 (➖ 0)
ResolveLibrary time 0.02 0.02 (➖ 0)
Program time 1.06 1.13 (🔽🟢 -0.07)
Bind time 0.44 0.42 (🔺 0.02)
Total time 1.5 1.55 (🔽🟢 -0.05)

Copy link
Member

@KATT KATT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a vercel deployment with a db + repo in the trpc org + subtree?

(Oooor just add drizzle to the existing example)

@@ -0,0 +1 @@
AUTH_SECRET=FlIbvvIt9KQXVBcg0wKpcrHMwGA5RNxpxn826LdbBF8=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't store stuff like this in git

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha just wanted the example to start right up 😅😅 not like that auth token does anythign secret

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but if people clone the project they will get the a bad setup, .env should be in .gitignore :)

form={form}
handleSubmit={async (values) => {
const promise = addPost(values);
return toast.promise(promise, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this toast twice on errors? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the db really be checked in? shouldn't that be lazily created with migrations or smth?

can we do something that works to deploy on vercel? like sqlite locally and pg on vercel?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants