Add batchInterval option to dataLoader #5474
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@stereosteve is attempting to deploy a commit to the trpc Team on Vercel. A member of the Team first needs to authorize it. |
juliusmarminge
requested changes
Feb 13, 2024
KATT
requested changes
Mar 1, 2024
There was a problem hiding this comment.
I wonder what the desired behavior should be when triggering another fetch while one is pending - should we further debounce it? That's what we did in #914
- Needs JSDoc about the option
- Should be an options object
- Needs docs in https://trpc.io/docs/client/links/httpBatchLin
| @@ -39,6 +39,7 @@ const throwFatalError = () => { | |||
| */ | |||
| export function dataLoader<TKey, TValue>( | |||
| batchLoader: BatchLoader<TKey, TValue>, | |||
| batchInterval = 0, | |||
There was a problem hiding this comment.
Make this an options object instead
Suggested change
| batchInterval = 0, | |
| opts: { | |
| /** | |
| * .......... docs | |
| */ | |
| batchInterval?: number; | |
| } = {}, |
Comment on lines
7
to
+9
| HTTPLinkBaseOptions<TRoot> & { | ||
| maxURLLength?: number; | ||
| batchInterval?: number; |
There was a problem hiding this comment.
This could be
HTTPLinkBaseOptions<TRoot> & DataLoaderOptions & { maxURLLength?: '..' }that way, it inherits whatever docs and options we add on dataloader
| const query = dataLoader<Operation, HTTPResult>(batchLoader('query')); | ||
| const query = dataLoader<Operation, HTTPResult>( | ||
| batchLoader('query'), | ||
| opts.batchInterval, |
There was a problem hiding this comment.
Suggested change
| opts.batchInterval, | |
| opts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Adds an option to
httpBatchLinkto configure abatchIntervalin milliseconds.This is an option that exists in dataloader and can be helpful if rendering of items in a list is spread out across multiple event loop ticks.
✅ Checklist