Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(next/app-dir):
contextCache
to control context values to add tocacheTag
#5458feat(next/app-dir):
contextCache
to control context values to add tocacheTag
#5458Changes from 3 commits
6f32a91
7ee54e8
6cfe7f4
cf3c99f
6989a2e
b29441a
655888e
dfb02d1
a8e88f1
336f480
d133445
8e35dda
726931d
2f5fdff
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while we don't have docs for these stuff yet, maybe include this in the example we have that's using this link so that people can know about it somehow.
i'd almost be inclined to make it required even since it's a vital part of getting the right cache key and making sure different users doesn't share the same cache entries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest making this property
| undefined
instead of partial so that user is explicitly passingundefined
if he doesn't want to manipulate the cache key.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
included in the example, and made the property
| undefined
.Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.