Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add @typescript-eslint/method-signature-style #5445

Open
wants to merge 11 commits into
base: next
Choose a base branch
from

Conversation

KATT
Copy link
Member

@KATT KATT commented Feb 4, 2024

https://www.totaltypescript.com/method-shorthand-syntax-considered-harmful

🎯 Changes

add @typescript-eslint/method-signature-style

Copy link

vercel bot commented Feb 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-prisma-starter ✅ Ready (Inspect) Visit Preview Mar 1, 2024 10:33am
og-image ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 10:33am
trpc-next-app-dir ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 10:33am
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 10:33am

Copy link

github-actions bot commented Feb 4, 2024

Diagnostics Comparison

Numbers

Metric PR next
Files 774 774 (➖ 0)
Lines of Library 40,241 40,241 (➖ 0)
Lines of Definitions 117,156 117,161 (🔽🟢 -5)
Lines of TypeScript 4,967 4,967 (➖ 0)
Lines of JavaScript 0 0 (➖ 0)
Lines of JSON 0 0 (➖ 0)
Lines of Other 0 0 (➖ 0)
Identifiers 173,315 173,320 (🔽🟢 -5)
Symbols 107,780 107,712 (🔺 68)
Types 89 89 (➖ 0)
Instantiations 0 0 (➖ 0)
Memory used 167,922 168,543 (🔽🟢 -621)
Assignability cache size 0 0 (➖ 0)
Identity cache size 0 0 (➖ 0)
Subtype cache size 0 0 (➖ 0)
Strict subtype cache size 0 0 (➖ 0)

Timings and averages

Metric PR next
max (s) 4.162 4.281 (🔽🟢 -0.12)
min (s) 4.162 4.281 (🔽🟢 -0.12)
avg (s) 4.162 4.281 (🔽🟢 -0.12)
median (s) 4.162 4.281 (🔽🟢 -0.12)
length 1 1 (➖ 0)
unstable timings

Unstable

Timings are not reliable in here

Metric PR next
I/O Read time 0.04 0.05 (🔽🟢 -0.01)
Parse time 0.71 0.71 (➖ 0)
ResolveTypeReference time 0.03 0.03 (➖ 0)
ResolveModule time 0.1 0.11 (🔽🟢 -0.01)
ResolveLibrary time 0.02 0.02 (➖ 0)
Program time 1.03 1.05 (🔽🟢 -0.02)
Bind time 0.41 0.43 (🔽🟢 -0.02)
Total time 1.44 1.47 (🔽🟢 -0.03)

juliusmarminge
juliusmarminge previously approved these changes Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants