Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/Who's using tRPC #5143

Merged
merged 14 commits into from Dec 17, 2023
Merged

feat/Who's using tRPC #5143

merged 14 commits into from Dec 17, 2023

Conversation

kwaimind
Copy link
Contributor

Hey tRPC team,

I took a look at #1290 and tried to build it as a feature for the www landing page to show who is using tRPC.

I wanted to bring a list of company logos to the landing page for social proof, and to bring this github issue/discussion to life for future devs. I didn't add all logos, and wanted to get feedback on if this is a direction the www team wants to take.

If I missed the point here and #1290 is supposed to be a discussion and not a feature, then just let me know 🫡

Input needed: Looking for suggestions on the text, which is currently:

Headline: As used by
Description: tRPC is tried and trusted by leading tech teams

We should also agree on if logos should follow some kind of template, and if they should be in colour or black?

Closes #1290

🎯 Changes

What changes are made in this PR? Is it a feature or a bug fix?

  • Feature to add "companies using tRPC" to the homepage
  • Tailwind animated "carousel" of svgs/pngs

✅ Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
    I have added or updated the tests related to the changes made.

@kwaimind kwaimind requested a review from a team as a code owner December 12, 2023 09:07
Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
trpc-next-app-dir ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2023 7:21pm
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2023 7:21pm

Copy link

vercel bot commented Dec 12, 2023

@kwaimind is attempting to deploy a commit to the trpc Team on Vercel.

A member of the Team first needs to authorize it.

@juliusmarminge
Copy link
Member

I think it's a nice addition

Contrast definitely needs fixed though:

CleanShot 2023-12-13 at 18 49 18@2x

@kwaimind
Copy link
Contributor Author

I think it's a nice addition

Contrast definitely needs fixed though:

CleanShot 2023-12-13 at 18 49 18@2x

Great point, that's my bad. I went ahead and:

  1. converted all svgs to black & optimized them
  2. inverted the svg when in dark mode with css

Let me know what you think

Copy link
Member

@KATT KATT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@KATT KATT merged commit a130e20 into trpc:main Dec 17, 2023
39 of 41 checks passed
@kwaimind
Copy link
Contributor Author

Tackar tackar 🫡

@kwaimind kwaimind deleted the feat/company-logos branch December 17, 2023 22:10
Copy link

This pull request has been locked because we are very unlikely to see comments on closed issues. If you think, this PR is still necessary, create a new one with the same branch. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

👋 Who's using tRPC?
3 participants