Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(v11): remove some deprecated stuff #5026

Merged
merged 2 commits into from Nov 11, 2023
Merged

chore(v11): remove some deprecated stuff #5026

merged 2 commits into from Nov 11, 2023

Conversation

juliusmarminge
Copy link
Member

@juliusmarminge juliusmarminge commented Nov 9, 2023 •
edited

Relates to #3496

@juliusmarminge juliusmarminge requested a review from a team as a code owner November 9, 2023 20:00
@vercel Vercel
Copy link

vercel bot commented Nov 9, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-prisma-starter ❌ Failed (Inspect) Nov 9, 2023 8:23pm
og-image ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 8:23pm
trpc-next-app-dir ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 8:23pm
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 8:23pm

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023 •
edited

Diagnostics Comparison

Numbers

Metric PR next main
Files 712 712 (➖ 0) 724 (🔽🟢 -12)
Lines of Library 39145 39145 (➖ 0) 39145 (➖ 0)
Lines of Definitions 112650 112681 (🔽🟢 -31) 113170 (🔽🟢 -520)
Lines of TypeScript 4868 4868 (➖ 0) 4868 (➖ 0)
Lines of JavaScript 0 0 ( N/A) 0 ( N/A)
Lines of JSON 0 0 ( N/A) 0 ( N/A)
Lines of Other 0 0 ( N/A) 0 ( N/A)
Identifiers 179690 179748 (🔽🟢 -58) 180727 (🔽🟢 -1037)
Symbols 105479 105499 (🔽🟢 -20) 106022 (🔽🟢 -543)
Types 88 88 (➖ 0) 88 (➖ 0)
Instantiations 0 0 ( N/A) 0 ( N/A)
Memory used 180290 178810 (🔺 1480) 183967 (🔽🟢 -3677)
Assignability cache size 0 0 ( N/A) 0 ( N/A)
Identity cache size 0 0 ( N/A) 0 ( N/A)
Subtype cache size 0 0 ( N/A) 0 ( N/A)
Strict subtype cache size 0 0 ( N/A) 0 ( N/A)

Timings

Timings are not reliable in CI - we need to run the benchmark multiple times to get a good average.

Metric PR next main
I/O Read time 0.04 0.05 (🔽🟢 -0.01) 0.05 (🔽🟢 -0.01)
Parse time 0.87 1.18 (🔽🟢 -0.31) 0.86 (🔺 0.01)
ResolveTypeReference time 0.03 0.05 (🔽🟢 -0.02) 0.03 (➖ 0)
ResolveModule time 0.1 0.13 (🔽🟢 -0.03) 0.1 (➖ 0)
ResolveLibrary time 0.03 0.04 (🔽🟢 -0.01) 0.02 (🔺 0.01)
Program time 1.2 1.63 (🔽🟢 -0.43) 1.18 (🔺 0.02)
Bind time 0.43 0.64 (🔽🟢 -0.21) 0.46 (🔽🟢 -0.03)
Total time 1.63 2.28 (🔽🟢 -0.65) 1.65 (🔽🟢 -0.02)

juliusmarminge
juliusmarminge commented Nov 9, 2023
View reviewed changes
packages/react-query/src/server/ssgProxy.ts
@@ -42,7 +42,7 @@ import {
interface CreateSSGHelpersInternal<TRouter extends AnyRouter> {
router: TRouter;
ctx: inferRouterContext<TRouter>;
transformer?: ClientDataTransformerOptions;
transformer?: DataTransformerOptions;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not completely sure of the differences between all the different DataTransformer types to be fair, so this should probably be validated @KATT

@juliusmarminge juliusmarminge merged commit a69ae85 into next Nov 11, 2023
36 of 38 checks passed
@juliusmarminge juliusmarminge deleted the rm-deprecated-stuff branch November 11, 2023 16:32
@juliusmarminge juliusmarminge mentioned this pull request Nov 11, 2023
Open
22 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KATT KATT KATT approved these changes

Assignees
No one assigned
Labels
@trpc/client @trpc/react-query @trpc/server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juliusmarminge @KATT