Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename and deprecate proxy named stuff #4932

Merged
merged 9 commits into from
Oct 20, 2023
Merged

refactor: rename and deprecate proxy named stuff #4932

merged 9 commits into from
Oct 20, 2023

Conversation

juliusmarminge
Copy link
Member

@juliusmarminge juliusmarminge commented Oct 17, 2023 •
edited

Part of #3496

Removes Proxy from names, re-exports old name marked as deprecated

went a bit crazy and did it for our tests too 😅

@vercel
Copy link

vercel bot commented Oct 17, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-prisma-starter ❌ Failed (Inspect) Oct 20, 2023 7:08am
og-image ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 7:08am
trpc-next-app-dir ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 7:08am
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 7:08am

@github-actions
Copy link

github-actions bot commented Oct 17, 2023 •
edited

Diagnostics Comparison

Numbers

Metric PR next main
Files 671 671 (➖ 0) 683 (🔽🟢 -12)
Lines of Library 39145 39145 (➖ 0) 39145 (➖ 0)
Lines of Definitions 110643 110631 (🔺 12) 111143 (🔽🟢 -500)
Lines of TypeScript 4868 4868 (➖ 0) 4868 (➖ 0)
Lines of JavaScript 0 0 ( N/A) 0 ( N/A)
Lines of JSON 0 0 ( N/A) 0 ( N/A)
Lines of Other 0 0 ( N/A) 0 ( N/A)
Identifiers 177554 177544 (🔺 10) 178550 (🔽🟢 -996)
Symbols 103643 103640 (🔺 3) 104179 (🔽🟢 -536)
Types 88 88 (➖ 0) 88 (➖ 0)
Instantiations 0 0 ( N/A) 0 ( N/A)
Memory used 178742 180404 (🔽🟢 -1662) 173080 (🔺 5662)
Assignability cache size 0 0 ( N/A) 0 ( N/A)
Identity cache size 0 0 ( N/A) 0 ( N/A)
Subtype cache size 0 0 ( N/A) 0 ( N/A)
Strict subtype cache size 0 0 ( N/A) 0 ( N/A)

Timings

Timings are not reliable in CI - we need to run the benchmark multiple times to get a good average.

Metric PR next main
I/O Read time 0.07 0.05 (🔺 0.02) 0.06 (🔺 0.01)
Parse time 1.45 1.35 (🔺 0.1) 1.62 (🔽🟢 -0.17)
ResolveTypeReference time 0.07 0.06 (🔺 0.01) 0.06 (🔺 0.01)
ResolveModule time 0.17 0.16 (🔺 0.01) 0.19 (🔽🟢 -0.02)
ResolveLibrary time 0.04 0.04 (➖ 0) 0.05 (🔽🟢 -0.01)
Program time 2.03 1.92 (🔺 0.11) 2.21 (🔽🟢 -0.18)
Bind time 0.8 0.79 (🔺 0.01) 0.84 (🔽🟢 -0.04)
Total time 2.83 2.71 (🔺 0.12) 3.05 (🔽🟢 -0.22)

@github-actions github-actions bot added the 🕸 www Stuff to do with the website (`/www` folder) label Oct 17, 2023
juliusmarminge
juliusmarminge commented Oct 17, 2023
View reviewed changes
examples/deno-deploy/src/client.ts Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk how to make deno resolve local package... reverting here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update import maps for that. There's no "nice" way to make it work locally for monorepo and remotely at the same time without it. It requires docs to be updated to reflect that.

Also not from that example readme is not true anymore:

Note: Deno Deploy does denoland/deploy_feedback#314.

@juliusmarminge juliusmarminge changed the title rename and deprecate proxy named stuff refactor: rename and deprecate proxy named stuff Oct 17, 2023
@juliusmarminge juliusmarminge marked this pull request as ready for review October 17, 2023 17:00
@juliusmarminge juliusmarminge requested review from a team as code owners October 17, 2023 17:00
@juliusmarminge juliusmarminge mentioned this pull request Oct 17, 2023
Open
22 tasks
KATT
KATT approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@KATT KATT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we wanna make sure the old alias works we could omit changing any tests as part of this

@KATT
Copy link
Member

KATT commented Oct 19, 2023 •
edited

((you can do something like git checkout origin/next packages/tests/server/**/*))

@juliusmarminge
Copy link
Member Author

juliusmarminge commented Oct 20, 2023 •
edited

If we wanna make sure the old alias works we could omit changing any tests as part of this

You can see all the tests passing here before making the test changes

https://github.com/trpc/trpc/actions/runs/6549848029/job/17787672965

@juliusmarminge juliusmarminge merged commit 7387cde into next Oct 20, 2023
37 of 39 checks passed
@juliusmarminge juliusmarminge deleted the rm-proxy-naming branch October 20, 2023 18:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kamilogorek kamilogorek kamilogorek left review comments

@KATT KATT KATT approved these changes

Assignees
No one assigned
Labels
@trpc/client @trpc/next @trpc/react-query 🕸 www Stuff to do with the website (`/www` folder)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@juliusmarminge @KATT @kamilogorek