-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update react query version #2240
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
So I've made some quick investigations, and I found out the following:
Next:
Any other suggestions are welcome. CC @KATT |
Feel free to remove our use of
What sort of stuff? Will it be impossible to support both?
Will it be impossible to support both versions? |
I don't think that's possible without having |
cc @dyaa update to |
also please get github sponsors working so I can send you money for it :) #1599 |
I'll send some more money if you fix it, just sent you a fiver for a beer or a coffee now 🍻 |
This PR currently has a merge conflict. Please resolve this and then re-add the |
Oops, I closed the wrong PR! |
03b22a2
to
1825753
Compare
1825753
to
23654f8
Compare
I'm bumping the version now to see if it fixes it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely, I just want to get some feedback from @trpc/trpc-core in regards to the requestContext
property
@@ -82,7 +82,7 @@ export interface TRPCRequestOptions { | |||
/** | |||
* Pass additional context to links | |||
*/ | |||
context?: OperationContext; | |||
requestContext?: OperationContext; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a note of this in https://alpha.trpc.io/docs/migrate-from-v9-to-v10 anywhere? I'll clean it up later.
@sachinraja @jlalmes what do you think we should do here now that the context
keyword is taken?
Some options:
- Put all trpc option under
trpc
- quite annoying for the 99% use-case but also nice to have a distinct place for "our" versus "theirs" in options - Call it
trpcContext
? Potentially prefix all our vars withtrpc
? operationContext
?opContext
?callContext
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to #2395.
Will merge this one and we can iterate as it's still alpha.
This reverts commit f8a6f19.
@all-contributors add @dyaa for code, test |
I've put up a pull request to add @dyaa! 🎉 |
This pull request has been locked because it had no new activity for 30 days. If you think, this PR is still necessary, create a new one with the same branch. Thank you. |
Closes #2352