Add the ability to set the GuzzleHttp\Client instance on the PHRETS\Session #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use PHRETS to connect to and download data from MRIS/BrightMLS.
We have a use case that requires our application, in a single runtime, to connect to more than one server. As is, this is impossible because the
PHRETS\SessioncallsPHRETSClientto manage a singleton instance ofGuzzleHttp\Client. This makes it impossible to authenticate more than one RETS session per runtime, which we need to be able to do.This is solved by adding a mutator to
PHRETS\Session, allowing for our application to set the instance ofGuzzleHttp\Clientat the time the session object is created.All of your unit tests are passing.