Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for CairoMakie to 0.12 for package test, (keep existing compat) #1936

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 10, 2024

This pull request changes the compat entry for the CairoMakie package from 0.10 to 0.10, 0.12 for package test.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

TODO

  • Update to Makie.jl v0.21
  • Remove older compatibility statements for Makie.jl etc. (if required)

@github-actions github-actions bot force-pushed the compathelper/new_version/2024-05-10-00-05-49-190-02195501927 branch from 24257b4 to 22c71fb Compare May 10, 2024 00:05
github-actions bot and others added 3 commits May 10, 2024 07:50
…eep existing compat) (#1935)

Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.16%. Comparing base (c221bca) to head (619575d).

Files Patch % Lines
ext/TrixiMakieExt.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1936      +/-   ##
==========================================
- Coverage   96.09%   91.16%   -4.94%     
==========================================
  Files         453      453              
  Lines       36481    36477       -4     
==========================================
- Hits        35055    33251    -1804     
- Misses       1426     3226    +1800     
Flag Coverage Δ
unittests 91.16% <0.00%> (-4.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ranocha
Copy link
Member

ranocha commented May 10, 2024

The CI failure looks real to me:

  type Camera3D has no field attributes
  Stacktrace:
    [1] getproperty(x::Makie.Camera3D, f::Symbol)
      @ Base ./Base.jl:37
    [2] iplot(pd::Trixi.PlotData2DTriangulated{StructArrays.StructArray{StaticArraysCore.SVector{4, Float64}, 2, NTuple{4, Matrix{Float64}}, Int64}, Matrix{Float64}, Matrix{Float64}, StructArrays.StructArray{StaticArraysCore.SVector{4, Float64}, 2, NTuple{4, Matrix{Float64}}, Int64}, StaticArraysCore.SVector{4, String}, Matrix{Int32}}; plot_mesh::Bool, show_axis::Bool, colormap::Symbol, variable_to_plot_in::Int64)
      @ TrixiMakieExt ~/work/Trixi.jl/Trixi.jl/ext/TrixiMakieExt.jl:265

see https://github.com/trixi-framework/Trixi.jl/actions/runs/9027943539/job/24807599498?pr=1936#step:7:3305

@asinghvi17 Since you created #1937, do you have a suggestion how to fix this?

@asinghvi17
Copy link

Ah I didn't see that! Will look into it.

@ranocha
Copy link
Member

ranocha commented May 10, 2024

Thanks a lot!

asinghvi17 and others added 2 commits May 13, 2024 15:33
* Fix old API usage for Camera3D

* Update Project.toml

* Update Project.toml

* Update Project.toml
@ranocha
Copy link
Member

ranocha commented May 13, 2024

Do you know in which version the shading options were updated like this?

┌ Warning: `shading = false` is not valid. Use `Makie.automatic`, `NoShading`, `FastShading` or `MultiLightShading`. Defaulting to `NoShading`.
└ @ Makie ~/.julia/packages/Makie/eziUH/src/lighting.jl:243

I would like to make sure that we don't get incompatible compatibility bounds in our Project.toml files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants