Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Sc/mhd treemesh 2d #1806

Draft
wants to merge 154 commits into
base: main
Choose a base branch
from
Draft

WIP: Sc/mhd treemesh 2d #1806

wants to merge 154 commits into from

Conversation

SimonCan
Copy link
Contributor

@SimonCan SimonCan commented Jan 16, 2024

This branch is a fork of the ns-treemesh-3d branch. It implements the compressible visco-resistive MHD equations in 2 dimensions on the treemesh.

Convergence test for examples/tree_3d_dgsem/elixir_mhd_diffusive_alfven_wave.jl:

####################################################################################################
l2
rho                 rho_v1              rho_v2              rho_v3              rho_e               B1                  B2                  B3                  psi                 
error     EOC       error     EOC       error     EOC       error     EOC       error     EOC       error     EOC       error     EOC       error     EOC       error     EOC       
5.18e-03  -         1.33e-02  -         7.05e-03  -         1.65e-02  -         7.95e-03  -         1.30e-02  -         7.93e-03  -         1.65e-02  -         2.54e-03  -         
4.50e-04  3.53      8.01e-04  4.05      4.66e-04  3.92      9.26e-04  4.15      2.80e-04  4.83      8.26e-04  3.98      4.63e-04  4.10      9.26e-04  4.15      2.99e-04  3.08      
2.76e-05  4.03      6.99e-05  3.52      3.86e-05  3.59      8.17e-05  3.50      1.08e-05  4.70      7.18e-05  3.52      4.03e-05  3.52      7.99e-05  3.53      3.21e-05  3.22      

mean      3.78      mean      3.79      mean      3.76      mean      3.83      mean      4.76      mean      3.75      mean      3.81      mean      3.84      mean      3.15      
----------------------------------------------------------------------------------------------------
linf
rho                 rho_v1              rho_v2              rho_v3              rho_e               B1                  B2                  B3                  psi                 
error     EOC       error     EOC       error     EOC       error     EOC       error     EOC       error     EOC       error     EOC       error     EOC       error     EOC       
1.14e-02  -         3.23e-02  -         1.86e-02  -         5.64e-02  -         3.34e-02  -         4.37e-02  -         2.82e-02  -         5.62e-02  -         1.37e-02  -         
9.42e-04  3.60      3.07e-03  3.40      1.69e-03  3.46      3.55e-03  3.99      1.29e-03  4.70      3.45e-03  3.66      2.21e-03  3.68      3.52e-03  4.00      9.08e-04  3.92      
5.86e-05  4.01      2.50e-04  3.61      1.24e-04  3.77      3.01e-04  3.56      3.64e-05  5.14      2.73e-04  3.66      1.89e-04  3.54      2.73e-04  3.69      6.26e-05  3.86      

mean      3.80      mean      3.51      mean      3.62      mean      3.77      mean      4.92      mean      3.66      mean      3.61      mean      3.84      mean      3.89      
----------------------------------------------------------------------------------------------------
Dict{Symbol, Any} with 3 entries:
  :variables => ("rho", "rho_v1", "rho_v2", "rho_v3", "rho_e", "B1", "B2", "B3", "psi")
  :l2        => [3.7758, 3.78608, 3.75548, 3.82813, 4.76315, 3.75097, 3.81046, 3.84353, 3.15107]
  :linf      => [3.8024, 3.50665, 3.61503, 3.77391, 4.92067, 3.66201, 3.6093, 3.84236, 3.88718]

SimonCan and others added 30 commits June 26, 2023 16:31
Added interface coupling docs to the main menu.
Moved converter coupling section.
Added some documentation on coupling converters.
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 78 lines in your changes are missing coverage. Please review.

Project coverage is 95.87%. Comparing base (5185abd) to head (daef94b).
Report is 60 commits behind head on main.

Files Patch % Lines
src/equations/visco_resistive_mhd_2d.jl 0.00% 47 Missing ⚠️
.../tree_2d_dgsem/elixir_mhd_diffusive_convergence.jl 0.00% 31 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1806      +/-   ##
==========================================
+ Coverage   89.67%   95.87%   +6.20%     
==========================================
  Files         458      452       -6     
  Lines       36400    36247     -153     
==========================================
+ Hits        32640    34751    +2111     
+ Misses       3760     1496    -2264     
Flag Coverage Δ
unittests 95.87% <0.00%> (+6.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants