Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update L0_trace for DLIS-6462 #7134

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update L0_trace for DLIS-6462 #7134

wants to merge 4 commits into from

Conversation

indrajit96
Copy link
Contributor

Remove checking on trace_mode when trace_file update fails.

@yinggeh
Copy link
Contributor

yinggeh commented Apr 22, 2024

Can you please remove line 567 RET=0? This line resets RET thus failures before that were not captured. cc @GuanLuo

@indrajit96
Copy link
Contributor Author

Can you please remove line 567 RET=0? This line resets RET thus failures before that were not captured. cc @GuanLuo

Resolved

@yinggeh
Copy link
Contributor

yinggeh commented Apr 26, 2024

Would you merge into 24.04?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oandreeva-nv oandreeva-nv oandreeva-nv left review comments

@yinggeh yinggeh yinggeh approved these changes

@rmccorm4 rmccorm4 Awaiting requested review from rmccorm4

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@indrajit96 @yinggeh @rmccorm4 @oandreeva-nv