Enhance OTEL testing DLIS-6308 #7132
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Could you please add a description, clarifying what tests were added? |
|
Could you please attach a picture of a trace as displayed in jaeger with cancelled request. Another question, have you considered cases when request was cancelled, when it was in a queue and when it was already in a compute stage? |
Fixed this, added a model which waits for a delay before executing hence cancellation request is recieved before the execution starts |
| headers=headers, | ||
| expected_number_of_spans=expected_number_of_spans, | ||
| expected_counts=expected_counts, | ||
| expected_parent_span_dict=expected_parent_span_dict, |
There was a problem hiding this comment.
| expected_parent_span_dict=expected_parent_span_dict, | |
| expected_parent_span_dict=expected_parent_span_dict |
| @@ -232,7 +292,7 @@ def _test_resource_attributes(self, attributes): | |||
| ), | |||
| ) | |||
|
|
|||
| def _verify_contents(self, spans, expected_counts): | |||
| def _verify_contents(self, spans, expected_counts, is_cancel): | |||
There was a problem hiding this comment.
nit: is_cancel -> is_cancelled
and please update Args field bellow on L304 with a new field.
| @@ -397,7 +474,7 @@ def _test_trace( | |||
| ][0] | |||
| self.assertEqual(len(parsed_spans), expected_number_of_spans) | |||
|
|
|||
| self._verify_contents(parsed_spans, expected_counts) | |||
| self._verify_contents(parsed_spans, expected_counts, False) | |||
There was a problem hiding this comment.
I would recommend not use just False or True as an argument, it might be not clear what they stand for in this context. Please use is_cancelled=False
…erver/server into indrajit_otel_testing
| inputs[1].set_data_from_numpy(np.arange(1, dtype=np.float32)) | ||
| inputs.append(grpcclient.InferInput("INPUT2", [1], "FP32")) | ||
| inputs[2].set_data_from_numpy(np.arange(1, dtype=np.float32)) | ||
| future_1 = triton_client_grpc.async_infer( |
Check notice
Code scanning / CodeQL
Unused local variable Note
|
Can you update the PR title to be more descriptive? (cancellation, decoupled responses, etc. rather than JIRA ticket number) |
Add tests