Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inference command sample in README.md #6868

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jasoncwik
Copy link

The inference sample in README.md did not work for me and I noticed there was a missing line continuation in the command line.

The inference sample did not work for me. Looks like there was a missing line continuation in the inference command.
@jasoncwik
Copy link
Author

CLA emailed to triton-cla@nvidia.com

@jasoncwik
Copy link
Author

Tested and confirmed fix:

$ docker run -it --rm --net=host nvcr.io/nvidia/tritonserver:24.01-py3-sdk \
/workspace/install/bin/image_client -m densenet_onnx -c 3 -s INCEPTION /workspace/images/mug.jpg

=================================
== Triton Inference Server SDK ==
=================================

NVIDIA Release 24.01 (build 80100517)

Copyright (c) 2018-2023, NVIDIA CORPORATION & AFFILIATES.  All rights reserved.

Various files include modifications (c) NVIDIA CORPORATION & AFFILIATES.  All rights reserved.

This container image and its contents are governed by the NVIDIA Deep Learning Container License.
By pulling and using the container, you accept the terms and conditions of this license:
https://developer.nvidia.com/ngc/nvidia-deep-learning-container-license

WARNING: The NVIDIA Driver was not detected.  GPU functionality will not be available.
   Use the NVIDIA Container Toolkit to start this container with GPU support; see
   https://docs.nvidia.com/datacenter/cloud-native/ .

Request 0, batch size 1
Image '/workspace/images/mug.jpg':
    15.349567 (504) = COFFEE MUG
    13.227467 (968) = CUP
    10.424895 (505) = COFFEEPOT

@rmccorm4
Copy link
Collaborator

rmccorm4 commented Feb 9, 2024

Hey Jason, thanks for the contribution!

Similar to step 1, I believe those are intended to be 2 separate commands, not a single one. If you copy and paste them individually, the sample should work. The difference is whether or not you'll stay in the container interactively after the command finishes.

Are you seeing otherwise?

@rmccorm4 rmccorm4 added the investigating The developement team is investigating this issue label Feb 9, 2024
@jasoncwik
Copy link
Author

Got it. I guess it wasn't immediately clear to me that you wanted to launch the container and then paste the command inside the container. I had copied and pasted both lines and the 2nd line paste didn't work automatically for some reason. IMO unless you have a reason to keep the user in the container, it's a little cleaner to make it one line, but I'll defer to you.

Oh, I suppose if it's decided to make it one line you could remove the -it too...

@jbkyang-nvi
Copy link
Contributor

CLA is approved. @jasoncwik can you rebase as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigating The developement team is investigating this issue
Development

Successfully merging this pull request may close these issues.

None yet

3 participants