Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenVINO 2023.3 #6827

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

atobiszei
Copy link

@atobiszei atobiszei commented Jan 24, 2024

@atobiszei atobiszei force-pushed the atobisze_update_OpenVINO_to_2023.3 branch from 6aa667a to a843d24 Compare January 24, 2024 15:34
@nnshah1 nnshah1 requested a review from mc-nv February 1, 2024 16:00
@kthui
Copy link
Contributor

kthui commented Feb 1, 2024

Hi @atobiszei, thanks for updating the OpenVINO version for Triton. We noticed there is an issue building OpenVINO on Windows fatal: path 'versions/baseline.json' exists on disk, but not in 'db0473513e5dc73ec6b6f431ff05d2f398eea042'. Would you be able to investigate further?

C:\workspace\openvino\build>cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=C:/workspace/install -DENABLE_TESTS=OFF .. 
         -- Building for: Visual Studio 17 2022
         -- Running vcpkg install
    17>CUSTOMBUILD : error : while checking out baseline from commit 'db0473513e5dc73ec6b6f431ff05d2f398eea042', failed to `git show` versions/baseline.json. This may be fixed by fetching commits with `git fetch`. [C:\tmp\tritonbuild\openvino\build\ov_target.vcxproj]
    17>CUSTOMBUILD : error : git failed with exit code: (128). [C:\tmp\tritonbuild\openvino\build\ov_target.vcxproj]
         fatal: path 'versions/baseline.json' exists on disk, but not in 'db0473513e5dc73ec6b6f431ff05d2f398eea042'
         while checking out baseline db0473513e5dc73ec6b6f431ff05d2f398eea042

@atobiszei
Copy link
Author

Hi @kthui could you share more details about your Windows machine? We did not encounter issues when building pure OV on Win11:

cmake -G "Visual Studio 17 2022" -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=C:/temp/install -DENABLE_TESTS=OFF ..
cmake --build . --config Release --verbose -j8

Where does the commit sha db0473513e5dc73ec6b6f431ff05d2f398eea042 comes from? It is not OV 2023.3.0 tag.

@kthui
Copy link
Contributor

kthui commented Feb 7, 2024

Hi @atobiszei, the windows machine is running Windows 10 Enterprise version 20H2. The build is run on Docker which the base container is setup from this instruction. All the build steps are then invoked by the build.py.

I think the commit sha db0473513e5dc73ec6b6f431ff05d2f398eea042 is from OpenVINO. See the "builtin-baseline" here.

@kthui kthui mentioned this pull request Feb 15, 2024
@mc-nv mc-nv requested a review from kthui March 4, 2024 17:39
@mc-nv
Copy link
Collaborator

mc-nv commented Mar 4, 2024

@kthui , suppose we had picked up this change, am I right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants