Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OTEL_SERVICE_NAME environment variable if set #6769

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HennerM
Copy link
Contributor

@HennerM HennerM commented Jan 7, 2024

triton-inference-server is the default OpenTelemetry service name if none other is set. Most libraries and applications read the OTEL_SERVICE_NAME environment variable though to get the name. This is override by the explicit setting of triton-inference-server.

Fixes #5987

@oandreeva-nv oandreeva-nv self-requested a review January 11, 2024 23:35
@oandreeva-nv
Copy link
Contributor

oandreeva-nv commented Jan 11, 2024

Thanks for this PR!
I think it would need to be re-based later, when this PR: #6785 is merged (end of this week).

I would like to also suggest to write a test, e.g. export OTEL_SERVICE_NAME before server start for opentelemetry unittests, and add a subroutine for _test_trace

Please feel free to explicitly tag me or assign me as a reviewer for OTel PR's

@oandreeva-nv
Copy link
Contributor

@HennerM, please rebase this PR.
As for tests, I think it would be enough for now to simply export environment variable OTEL_SERVICE_NAME here,
start server, send request and grep service name, from collected traces. You can refer to how to do it here , and sample grep command here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

OpenTelemetry Tracing allow to configure service name
2 participants