Fixes for Clang warnings #6768
Open
Fixes for Clang warnings #6768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was trying to compile triton server with default Clang 15 and got a few warnings that triggered as errors, among those: * deprecation errors from open telemetry showing up, which shouldn't be an issue here. They come up because the headers aren't included as "SYSTEM" headers. * unused parameter in TritonParser::SetGlobalTraceArgs(). There is a `explicit_disable_trace` passed as bool, that was updated but never read. I believe this was intended to be a `bool&` @oandreeva-nv ? (error: parameter 'explicit_disable_trace' set but not used [-Werror,-Wunused-but-set-parameter]) * An unused `[this]` capture (-Wunused-lambda-capture) * Assignment with `std::move` of temporary variable resulting in: ` error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]` I am not quite sure what's the problem, but I think the std::move is redundant here anyway? * a few conditionally uninitialised variables in tests variable 'ba_memory_type' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] * unused private field in ` HTTPAPIServer`: error: private field 'end_' is not used [-Werror,-Wunused-private-field] bool end_{false};
HennerM
force-pushed
the
fix-clang-15-warnings
branch
from
18d6052
to
975036a
Compare
This was referenced Jan 7, 2024
| @@ -2134,7 +2134,7 @@ void | |||
| TritonParser::SetGlobalTraceArgs( | |||
| TritonServerParameters& lparams, bool trace_level_present, | |||
| bool trace_rate_present, bool trace_count_present, | |||
| bool explicit_disable_trace) | |||
| bool& explicit_disable_trace) | |||
There was a problem hiding this comment.
Nice catch! Thanks for the fix
|
Hi @HennerM, thanks for the contributions, these look great! Can you update the branch and resolve the conflicts? Then we can run some quick tests to make sure nothing breaks and approve. |
rmccorm4
added
the
investigating
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to compile triton server with default Clang 15 and got a few warnings that triggered as errors, among those:
explicit_disable_tracepassed as bool, that was updated but never read. I believe this was intended to be abool&@oandreeva-nv ? (error: parameter 'explicit_disable_trace' set but not used [-Werror,-Wunused-but-set-parameter])[this]capture (-Wunused-lambda-capture)std::moveof temporary variable resulting in:error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]I am not quite sure what's the problem, but I think the std::move is redundant here anyway?HTTPAPIServer: error: private field 'end_' is not used [-Werror,-Wunused-private-field]bool end_{false};
There is more in the core and backend repos that I will raise separately