Allow users to specify github organizations for triton core, backend, common, third-party, etc. #6668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClifHouck
force-pushed
the
clif/build_cmake_improvements
branch
from
62b2bfb
to
5971f90
Compare
|
Created an issue for this #6718 |
ClifHouck
force-pushed
the
clif/build_cmake_improvements
branch
from
5971f90
to
105dc8c
Compare
ClifHouck
force-pushed
the
clif/build_cmake_improvements
branch
from
105dc8c
to
b9fc93d
Compare
|
With this change some of the variable values will be hidden from CMake and it's control would go to the wrapper and user input... We need to review it more close to make sure that it's suitable for Triton. |
This was referenced Mar 2, 2024
ClifHouck
force-pushed
the
clif/build_cmake_improvements
branch
from
b9fc93d
to
186b369
Compare
ClifHouck
force-pushed
the
clif/build_cmake_improvements
branch
from
186b369
to
4ffffc5
Compare
|
It seems like there's some work going on to support this PR. Any feedback or review of the work done in this PR would be appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds several CMake variables to allow the use of other github organizations for triton core, backend, common, third-party, etc. That way a developer can easily pull in changes from their own forks of triton related libraries and have it included in their build process.