Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix L0_backend_python lifecycle test #5597

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Fix L0_backend_python lifecycle test #5597

merged 1 commit into from
Apr 6, 2023

Conversation

krishung5
Copy link
Contributor

Fixed the check for the error message as the returned error message starts with some error code, [400] Failed to process the request(s)..., which failed the check str(e.exception).startswith

@krishung5 krishung5 requested a review from Tabrizian April 5, 2023 19:31
rmccorm4
rmccorm4 approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI there is a built-in assertIn instead of assertTrue, but this is fine.

@krishung5 krishung5 merged commit a2e8e61 into main Apr 6, 2023
2 checks passed
@krishung5 krishung5 deleted the krish-fix-python-lifecycle branch April 6, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tabrizian Tabrizian Tabrizian approved these changes

@tanmayv25 tanmayv25 tanmayv25 approved these changes

@rmccorm4 rmccorm4 rmccorm4 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@krishung5 @Tabrizian @tanmayv25 @rmccorm4