Add python client unit testing to the CI #5591
Conversation
debermudez
force-pushed
the
dbermudez-add-client-testing-to-ci
branch
3 times, most recently
from
a69e95d
to
8716b4a
Compare
debermudez
force-pushed
the
dbermudez-add-client-testing-to-ci
branch
from
8716b4a
to
3e16059
Compare
| @@ -205,6 +205,10 @@ RUN mkdir qa | |||
| COPY qa/L0_sdk qa/L0_sdk | |||
| COPY qa/L0_client_build_variants qa/L0_client_build_variants | |||
|
|
|||
| # Create a directory for all the python client tests to enable unit testing | |||
| RUN mkdir -p qa/python_client_unit_tests/ | |||
| COPY --from=sdk_build /workspace/client/src/python/library/tests/* qa/python_client_unit_tests/ | |||
There was a problem hiding this comment.
Nit: To make this consistent with the previous COPY commands and prevent COPY from being called multiple times on each file in the directory, you may want to update this line to:
COPY --from=sdk_build /workspace/client/src/python/library/tests qa/python_client_unit_tests
There was a problem hiding this comment.
I wasnt sure if dockerfiles worked exactly like unix commands.
In unix, that grabs the directory plus contents. I only want the contents
|
Great work on these! More unit tests are great. As a general comment, we need to be careful about including additional files in the SDK container that we ship. These are pretty small files, but we want to keep the containers as small as possible. We could look at other approaches. For example, this is really just copying files from the client repo to the SDK container. It'd probably be easy to create a placeholder test in server/qa that does a minimal clone of the client repo to copy just these files and runs this test. Also, if I'm reading your other PR right, these tests happen in the QA container anyway, right? I may be missing something, but I don't think copying them into the SDK container will run correctly. |
No description provided.