Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry Tracing allow to configure service name #5987

Open
Legion2 opened this issue Jun 24, 2023 · 1 comment · May be fixed by #6769
Open

OpenTelemetry Tracing allow to configure service name #5987

Legion2 opened this issue Jun 24, 2023 · 1 comment · May be fixed by #6769
Assignees
Labels
enhancement New feature or request

Comments

@Legion2
Copy link

Legion2 commented Jun 24, 2023

Is your feature request related to a problem? Please describe.
We are using the Open Telemetry tracing feature of triton, however we are not able to configure the service.name of the exported traces.

Describe the solution you'd like
With most Open Telemetry SDKs the service name can be configured via the environment variable OTEL_SERVICE_NAME, see here. However when I tested this with triton the service name still was the default value unknown_service after I set the environment variable.

Describe alternatives you've considered
As an alternative the service name can be configured via a triton tracing config flag.

Additional context
The service name is a very important attribute of span, which allows to build a service graph and visualize the different services which are part of the trace.

@oandreeva-nv oandreeva-nv self-assigned this Jun 26, 2023
@oandreeva-nv
Copy link
Contributor

Thank you for reporting this and the detailed feedback. Triton currently provides a limited support for OpenTelemetry and this functionality will be added in upcoming releases.

@oandreeva-nv oandreeva-nv added the enhancement New feature or request label Jun 26, 2023
@HennerM HennerM linked a pull request Jan 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

2 participants