PA should check whether user-supplied inputs exist in the model #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgerdesnv
reviewed
Apr 26, 2024
src/c++/perf_analyzer/data_loader.cc
Outdated
| @@ -121,6 +139,17 @@ DataLoader::ReadDataFromDir( | |||
| SerializeStringTensor(output_string_data, &it->second); | |||
| } | |||
| } | |||
|
|
|||
| for (const auto& file : std::filesystem::directory_iterator(data_directory)) { | |||
There was a problem hiding this comment.
This is duplicated from above?
Also, I don't think it is correct. It appears that output validation files would also be valid.
There was a problem hiding this comment.
Thanks for catching this! I tried a lot of different approaches and must have missed this during clean-up. I'll remove it.
Can you explain the output validation file part? This may be something new to me.
There was a problem hiding this comment.
Oh, I think I understand. This only covers inputs. One second, I'll push a commit to cover outputs as well.
There was a problem hiding this comment.
Removed the duplicate and added outputs to the I/O which is checked. It builds and looks to have the same unit test failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user provides inputs that the model does not support, then an error should be returned.
A few unit tests need to be updated for this PR. They are failing due to the mocks and logic expecting incorrect behavior (e.g. missing directories to not be checked, extra inputs to be ignored).