Convert Hive errors in IcebergParquetFileWriter to Iceberg errors #21932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takezoe
force-pushed
the
convert-iceberg-error
branch
from
fa6dfb4
to
e71dbf9
Compare
findepi
reviewed
May 14, 2024
| parquetFileWriter.appendRows(dataPage); | ||
| } | ||
| catch (TrinoException e) { | ||
| if (e.getErrorCode() == HIVE_WRITER_DATA_ERROR.toErrorCode()) { |
There was a problem hiding this comment.
having Iceberg and Delta connectors remap error codes in a bunch of places, i would rather think we should
- consider this OK for Iceberg and Delta to reuse hive error codes (no remapping)
- decouple parquet writer from hive, so that it doesn't use hive error codes (eg if we provide connector specific error codes in the constructor, no need for remapping)
There was a problem hiding this comment.
I see. Anyway this fix doesn't seem to make sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
IcebergParquetFileWriterthrows Hive errors if failed, but it would be better to throw Iceberg errors as other Iceberg file writers.Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: