Improve speed when listing columns in BigQuery #21920
Open
+1,126
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
reviewed
May 10, 2024
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/type/DecimalTypeInfo.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
May 10, 2024
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/type/TypeInfo.java
Show resolved
Hide resolved
nineinchnick
force-pushed
the
bigquery-bulk-columns
branch
3 times, most recently
from
d3fba84
to
f43ccd6
Compare
ebyhr
reviewed
May 13, 2024
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryTypeManager.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/type/TestTypeInfoUtils.java
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryTypeManager.java
Show resolved
Hide resolved
nineinchnick
force-pushed
the
bigquery-bulk-columns
branch
from
f43ccd6
to
6b34692
Compare
ebyhr
reviewed
May 15, 2024
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryTypeManager.java
Show resolved
Hide resolved
plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/BaseBigQueryConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/BaseBigQueryConnectorTest.java
Show resolved
Hide resolved
plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/TestBigQueryType.java
Show resolved
Hide resolved
plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/BaseBigQueryConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/type/TypeInfoUtils.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/type/TypeInfoUtils.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryTypeManager.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryTypeManager.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/type/TypeInfoUtils.java
Outdated
Show resolved
Hide resolved
nineinchnick
force-pushed
the
bigquery-bulk-columns
branch
2 times, most recently
from
a2bbea8
to
3654c2e
Compare
|
@ebyhr PTAL |
ebyhr
reviewed
May 20, 2024
plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/TestBigQueryType.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/BaseBigQueryConnectorTest.java
Outdated
Show resolved
Hide resolved
| FROM %s.INFORMATION_SCHEMA.COLUMNS | ||
| GROUP BY table_catalog, table_schema, table_name | ||
| """.formatted(quote(remoteSchemaName))); | ||
| String schemaName = client.toSchemaName(DatasetId.of(projectId, remoteSchemaName)); |
There was a problem hiding this comment.
Why do we need to build DatasetId and call getDataset method (when is it different from remoteSchemaName)?
There was a problem hiding this comment.
I added it for consistency. This connector has a local to remote names mapping.
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryTypeManager.java
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/type/PrimitiveTypeInfo.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/type/TypeInfoUtils.java
Outdated
Show resolved
Hide resolved
nineinchnick
force-pushed
the
bigquery-bulk-columns
branch
from
3654c2e
to
cc6a799
Compare
nineinchnick
force-pushed
the
bigquery-bulk-columns
branch
from
cc6a799
to
bf0cf78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A continuation of #21830. Test coverage of the type parser is at 99% of lines and 95% of branches. Original description below.
Using mini parser because BigQuery Java SDK doesn't support translating string to BigQuery type as far as I asked Google engineers.
This PR improves listing columns. Test with 169 tables is improved from 22s to 1.5s.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: