Fix reading NDV using Iceberg metadata on table with NULL partitions #21844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinyangli34
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
ebyhr
force-pushed
the
jinyang-fix_null_ndv_with_metadata
branch
from
c16bc98
to
20d7a4d
Compare
ebyhr
reviewed
May 8, 2024
|
|
||
| return NullableValue.of(column.getType(), prestoValue); | ||
| return partitionColumnValueStrings.get(columnId) | ||
| .map(value -> deserializePartitionValue(column.getType(), value, column.getName())) |
There was a problem hiding this comment.
Can we add @Nullable to deserializePartitionValue method in a separated commit?
| partitionColumnValueStrings.get(columnId).orElse(null), | ||
| column.getName()); | ||
|
|
||
| return NullableValue.of(column.getType(), prestoValue); |
There was a problem hiding this comment.
Did you consider calling the NullableValue constructor instead?
There was a problem hiding this comment.
Good question. I don't have a preference. I don't quite understand why it has both constructor and static methods.
Which way do you think is better?
There was a problem hiding this comment.
they have different semantics -- NullableValue.of doesn't allow null value
(i with the difference was more obvious from the NullableValue class's api)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use NullableValue.asNull for null values.
Additional context and related issues
Issue can be reproduced when query count distinct on partition with NULL value and optimize_metadata_queries session enabled.
Release notes
(x) Release notes are required, with the following suggested text: