Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the Trino Snowflake connector story post. #653

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add the Trino Snowflake connector story post. #653

wants to merge 2 commits into from

Conversation

bitsondatadev
Copy link
Member

Adding the Snowlfake blog

@bitsondatadev bitsondatadev self-assigned this May 3, 2024
@cla-bot cla-bot bot added the cla-signed label May 3, 2024
@yuuteng
Copy link
Contributor

yuuteng commented May 3, 2024

Cool article. Good for me.

mosabua
mosabua requested changes May 3, 2024
View reviewed changes
_posts/2024-05-03-trino-snowflake-bloomberg-oss-win.md Outdated Show resolved Hide resolved
_posts/2024-05-03-trino-snowflake-bloomberg-oss-win.md Outdated Show resolved Hide resolved
_posts/2024-05-03-trino-snowflake-bloomberg-oss-win.md Outdated Show resolved Hide resolved
_posts/2024-05-03-trino-snowflake-bloomberg-oss-win.md Outdated Show resolved Hide resolved
_posts/2024-05-03-trino-snowflake-bloomberg-oss-win.md Outdated Show resolved Hide resolved
_posts/2024-05-03-trino-snowflake-bloomberg-oss-win.md Outdated Show resolved Hide resolved
_posts/2024-05-03-trino-snowflake-bloomberg-oss-win.md Outdated Show resolved Hide resolved
_posts/2024-05-03-trino-snowflake-bloomberg-oss-win.md Outdated Show resolved Hide resolved
_posts/2024-05-03-trino-snowflake-bloomberg-oss-win.md Outdated Show resolved Hide resolved
_posts/2024-05-03-trino-snowflake-bloomberg-oss-win.md Outdated Show resolved Hide resolved
colebow
colebow reviewed May 6, 2024
View reviewed changes
Copy link
Member

@colebow colebow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great post. I have some comments, but feel free to disregard any of them, I think it's more important that it's clearly in your voice than polished to a T

_posts/2024-05-03-trino-snowflake-bloomberg-oss-win.md Outdated Show resolved Hide resolved
_posts/2024-05-03-trino-snowflake-bloomberg-oss-win.md Outdated Show resolved Hide resolved
_posts/2024-05-03-trino-snowflake-bloomberg-oss-win.md Outdated Show resolved Hide resolved
_posts/2024-05-03-trino-snowflake-bloomberg-oss-win.md Outdated Show resolved Hide resolved
_posts/2024-05-03-trino-snowflake-bloomberg-oss-win.md Outdated Show resolved Hide resolved
_posts/2024-05-03-trino-snowflake-bloomberg-oss-win.md Outdated Show resolved Hide resolved
_posts/2024-05-03-trino-snowflake-bloomberg-oss-win.md Outdated Show resolved Hide resolved
_posts/2024-05-03-trino-snowflake-bloomberg-oss-win.md Outdated Show resolved Hide resolved
_posts/2024-05-03-trino-snowflake-bloomberg-oss-win.md Outdated Show resolved Hide resolved
_posts/2024-05-03-trino-snowflake-bloomberg-oss-win.md Outdated Show resolved Hide resolved
colebow
colebow approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@colebow colebow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready - just needs a date update. We've also got a Trino Fest blog going up soon, maybe we should discuss on Slack to figure out the perfect timing

mosabua
mosabua approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go now. Some minor nits to fix. Before we merge we just gotta change to the appropriate date.

@mosabua mosabua marked this pull request as ready for review May 7, 2024 22:38
@bitsondatadev bitsondatadev force-pushed the snowflake-connector-post branch 2 times, most recently from 264ff2f to c55e0c2 Compare May 8, 2024 04:52
@bitsondatadev
Copy link
Member Author

Done!

@bitsondatadev
temp fix for the date
12272e1 
temp fix for the date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosabua mosabua mosabua approved these changes

@colebow colebow colebow approved these changes

@martint martint Awaiting requested review from martint

@dain dain Awaiting requested review from dain

@dprophet dprophet Awaiting requested review from dprophet

@yuuteng yuuteng Awaiting requested review from yuuteng

Assignees

@bitsondatadev bitsondatadev

Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bitsondatadev @yuuteng @mosabua @colebow