Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacement pass on clearly exception NotImplementedError #301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

morgangt
Copy link

Description

There is a desire to make the code unified, everywhere in the code to use the NotImplementedError exception in all abstract methods.

Non-technical explanation

Aesthetic desire to make everything logical

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

* Fix some things. ({issue}`issuenumber`)

@cla-bot
Copy link

cla-bot bot commented Dec 13, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@mdesmet
Copy link
Contributor

mdesmet commented Dec 14, 2022

IMHO this is not required, abc already takes care of that. You would get some error TypeError: Can't instantiate abstract class C with abstract methods my_abstract_method if you don't implement the abstract method. It is even possible to provide an implementation in the abstract method that can be called from the inherited class.

@morgangt
Copy link
Author

I think simple will be make the code unified
Because somewhere use
raise NotImplementedError
https://github.com/trinodb/trino-python-client/blob/master/trino/auth.py#L170
and somewhere use simple pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants