New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support reading log properties from file #340
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments - plus please update commit message to follow recommended style
|
||
Use the `log.*` properties from the [Trino logging properties | ||
documentation](https://trino.io/docs/current/admin/properties-logging.html) for further configuration. | ||
For additional configurations, use the `log.*` properties from the [Trino |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrap
documentation](https://trino.io/docs/current/admin/properties-logging.html) for further configuration. | ||
For additional configurations, use the `log.*` properties from the [Trino | ||
logging properties documentation](https://trino.io/docs/current/admin/properties-logging.html) and specify the path to `log.config` | ||
file using the `config` JVM options, such as `-Dconfig=var/log.config`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather follow the Trino approach of having on config.properties file and just all that to use log properties .. and any others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh so instead of two files (log.properties, log.config), you mean a single config.properties
file?
Description
Support reading log properties from file instead of command line using
-Dlog.<config>
.Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:
* Support reading log properties from file