Enable email notifier to send emails for health check failures #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prakhar10 can you fix the compile failure? |
|
@prakhar10 are you still working on this one or can we close this? |
yes, sorry for the delay, i'll get back on this by sunday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change enables to send email notifications for healthcheck failures on backend trino clusters.
New fields added in the NotifierConfiguration.java class:
enabled - To enable or disable sending emails for healthcheck failures
gatewayInstance - To specify gateway instance name in case there are multiple instances. This will be displayed in the email subject so that one can know in which instance the cluster is unhealthy.
customContent - To provide custom email body in case the default content is not very helpful.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(X) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:
*