Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt airlift as base framework #41

Open
mosabua opened this issue Sep 15, 2023 · 3 comments · May be fixed by #317
Open

Adopt airlift as base framework #41

mosabua opened this issue Sep 15, 2023 · 3 comments · May be fixed by #317
Assignees

Comments

@mosabua
Copy link
Member

mosabua commented Sep 15, 2023

Currently the project uses an old version of Dropwizard. Airlift is a superior alternative that is actively maintained and also used in Trino itself.

Rather than upgrading Dropwizard it might be better to move to Airlift and then take advantage of aspects such as easy tarball creation, config system, opentelemety support and much more. This is the preferred approach by @martint.

Potential an initial upgrade of dropwizard to fix the worst issues might still be a good step.

@mosabua mosabua changed the title Upgrade dropwizard and related dependencies Adopt airlift Sep 26, 2023
@mosabua mosabua changed the title Adopt airlift Adopt airlift as base framework Sep 26, 2023
@mosabua
Copy link
Member Author

mosabua commented Dec 15, 2023

This is done and part of version 5 onwards

@mosabua
Copy link
Member Author

mosabua commented Jan 19, 2024

Partially using airlift already .. but not as full base framework

@oneonestar
Copy link
Member

oneonestar commented Mar 24, 2024

Preparation phase (splittable):

Migration phase (all-at-once):

Things that can't migrate to Airlift:

  • GatewayRequestLogFactory
  • Some metrics provided by Dropwizard
  • Dropwizard Admin Web UI (:9082)

Uncertain things:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants