Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OpenTelemetry #46

Open
mosabua opened this issue Sep 15, 2023 · 3 comments
Open

Add support for OpenTelemetry #46

mosabua opened this issue Sep 15, 2023 · 3 comments

Comments

@mosabua
Copy link
Member

mosabua commented Sep 15, 2023

after dependencies like dropwizard are updated.

Needs architectural discussion how to best add this feature. Probably should talk to @electrum who added this to Trino.

@vishalya is interested on working on this feature.

@mosabua
Copy link
Member Author

mosabua commented Sep 27, 2023

@martint mentioned that this will be easier if we migrate to Airlift instead of using Dropwizard

Also fyi @willmostly

@lambrospetrou
Copy link

lambrospetrou commented Oct 27, 2023

This would be amazing to have. I have been looking to see if the gateway publishes metrics somehow that we could get them from outside, without implementing a custom listener module similar to ClusterStateListenerModule with our own ClusterStatsObserver.

Ideally, we would like to get those cluster stats metrics (and anything else from the gateway) without having to add any code in the gateway itself (or having code that depends on the gateway jar due to weird repo issues on our side), so that we can use the published gateway as-is, and then own the monitoring infra from the outside.

@mosabua
Copy link
Member Author

mosabua commented Apr 30, 2024

This depends on our move to airlift - see #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants