Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeouts to curl when building the hive image #180

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add timeouts to curl when building the hive image #180

wants to merge 1 commit into from

Conversation

nineinchnick
Copy link
Member

Some Hive artifacts may be slow to download, so make sure curl never gets stuck indefinitely.

@cla-bot cla-bot bot added the cla-signed label Sep 12, 2023
@nineinchnick nineinchnick mentioned this pull request Sep 12, 2023
Merged
hashhar
hashhar approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh it was curl timing out? I thought the tests time out because emuation is slow.

Oh well, we'll see if it fails more in future.

@wendigo
Copy link
Contributor

wendigo commented Sep 12, 2023

It's failing. Can we set some more generous timeout? 30 minutes ? (1800 s)

@nineinchnick
Copy link
Member Author

It failed at 83%. I bumped it to 1800s (30 minutes) and added a comment explaining why we choose this value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wendigo wendigo wendigo approved these changes

@hashhar hashhar hashhar approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
3 participants
@nineinchnick @wendigo @hashhar