Update configmap-coordinator.yaml remove indentation

[nabaruns]

With current chart, if we add

server:
    coordinatorExtraConfig: "query.client.timeout=5m"

then
config.properties in coordinator configMap turns out with config extra indented:

coordinator=true
node-scheduler.include-coordinator=false
http-server.http.port=8080
query.max-memory=2GB
query.max-memory-per-node=1GB
memory.heap-headroom-per-node=1GB
discovery-server.enabled=true
discovery.uri=http://localhost:8080
  query.client.timeout=5m

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[nineinchnick]

Can you update the PR description to explain why this change is necessary, instead of describing the change itself?

[nabaruns]

Can you update the PR description to explain why this change is necessary, instead of describing the change itself?

Please check now.

[nineinchnick]

Is the correct indentation level 0 or 2? In the example you have, it looks like there are 2 extra spaces now. Can you test this with two additional properties, like:

server:
    coordinatorExtraConfig: |
      query.client.timeout=5m
      query.execution-policy=phased

[nabaruns]

server:
coordinatorExtraConfig: |
query.client.timeout=5m
query.execution-policy=phased

Ok. I am using subchart with dependency. So when I have values.yaml as

trino:
  server:
    coordinatorExtraConfig: |
      query.client.timeout=5m
      query.execution-policy=phased

Then config.properties in coordinator configMap becomes:

  query.client.timeout=5m
query.execution-policy=phased

[nineinchnick]

And with your change that removes the indentation?

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[nabaruns]

And with your change that removes the indentation?

It works fine now. Refactored changes in both files for coordinator and worker. Kindly check.

[nineinchnick]

You could try this to preserve alignment and still have correct indentation.

Suggested change

	{{ .Values.server.coordinatorExtraConfig | indent 4 }}
	{{- .Values.server.coordinatorExtraConfig | indent 4 }}

[nabaruns]

This results in

  config.properties: |
    coordinator=true
    node-scheduler.include-coordinator=false
    http-server.http.port=8080
    query.max-memory=4GB
    query.max-memory-per-node=1GB
    discovery.uri=http://localhost:8080    query.max-run-time=3m
    - query.max-scan-physical-bytes=1GB

With values as

  coordinatorExtraConfig: |
    query.max-run-time=3m
    query.max-scan-physical-bytes=1GB

[luismacosta]

Hello @nabaruns

I was also facing this issue
My solution was:

• replace https://github.com/trinodb/charts/blob/main/charts/trino/templates/configmap-coordinator.yaml#L70 -> add

  {{- range $configValue := .Values.coordinator.additionalConfigProperties }}
    {{ $configValue }}
  {{- end }}

worker

• replace https://github.com/trinodb/charts/blob/main/charts/trino/templates/configmap-worker.yaml#L58 -> add

  {{- range $configValue := .Values.coordinator.additionalConfigProperties }}
    {{ $configValue }}
  {{- end }}

values.yaml

coordinator:
  additionalConfigProperties:
    - internal-communication.shared-secret=
    - password-authenticator.config-files=
    - http-server.authentication.allow-insecure-over-http=true
    - http-server.process-forwarded=true

[nineinchnick]

Fixed in 10e2060