New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/access control custom #88

Open

cdrappier wants to merge 2 commits into trinodb:main from cdrappier:feature/access-control-custom

cdrappier commented Jul 3, 2023

Hello,

This PR is made for give ability to set custom parameter inside access-control.properties file
It's needed to be compatible with a custom system access control implementation : https://trino.io/docs/current/develop/system-access-control.html

I'm not sure about the need of use range here, I've try to reproduce some code like in .Values.additionalConfigProperties

cdrappier added 2 commits

July 3, 2023 13:40


          Add ability to have custom access control definition

27847ff


          Add small documentation inside values.yaml about parameter for custom…

f106039

… access control

cla-bot bot added the cla-signed label

Member

nineinchnick commented May 22, 2024

@cdrappier please rebase and add a test for this, either in https://github.com/trinodb/charts/blob/main/test-values.yaml or a new file. If you'd add a new file, you'd have to reference it in test.sh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment