Enable password authentication if other authentication methods are also set #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… substring in Value authenticationType. Furthermore, it is now possible to use an externally created secret for the password file.
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
| @@ -1,4 +1,4 @@ | |||
| {{- if eq .Values.server.config.authenticationType "PASSWORD" }} | |||
| {{- if and (eq .Values.server.config.authenticationType "PASSWORD") (.Values.auth.passwordAuth) }} | |||
There was a problem hiding this comment.
No need to use contains here too?
|
Ah I just noticed #124 is merged, this might not be needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with password authentication working only when it is set as the only authentication type has been fixed. Since now in the templates it checks for a substring instead of equality.
Furthermore, it is now possible to use an externally created secret for the password file.