Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional prometheus pod monitor #135

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alaturqua
Copy link

Added Optional Prometheus Pod Monitor Support

Hey everyone,

I've added a new feature to Trino Helm charts that lets you easily monitor your Trino pods with Prometheus. This is totally optional, so you can turn it on or off as you like. Here's a quick rundown of what's new:

  • Turn Monitoring On/Off: You can switch monitoring on or off with monitoring.enabled. Handy if you're trying out different setups.
  • Set Up Your Metrics Endpoint: With monitoring.path and monitoring.port, you tell Prometheus where to find the metrics it needs to scrape. This means you can set it up exactly how you like it.
  • Control How Often Prometheus Checks for Metrics: Use monitoring.interval and monitoring.scrapeTimeout to control how often Prometheus looks for new metrics and how long it waits. This gives you control over the load and responsiveness of your monitoring setup.
  • Decide How Prometheus Handles Labels and Timestamps: The settings monitoring.honorLabels and monitoring.honorTimestamps let you control if Prometheus should use the labels and timestamps from your metrics as they are. This can help with sorting and understanding your data.
  • Add Extra Labels to Your Metrics: If you want more detail in your metrics, you can use monitoring.additionalPodTargetLabels to add extra labels from your pods. This is great for when you need to filter your metrics or dig into the details.

I hope this helps make monitoring with Prometheus. Looking forward to your feedback and suggestions!

Copy link

cla-bot bot commented Feb 20, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Isa.Inalcik.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

2 similar comments
Copy link

cla-bot bot commented Feb 20, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Isa.Inalcik.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Feb 20, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Isa.Inalcik.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@alaturqua
Copy link
Author

@cla-bot check

Copy link

cla-bot bot commented Mar 4, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Isa.Inalcik.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Mar 4, 2024

The cla-bot has been summoned, and re-checked this pull request!

@alaturqua
Copy link
Author

@cla-bot check

Copy link

cla-bot bot commented Mar 4, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Isa.Inalcik.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Mar 4, 2024

The cla-bot has been summoned, and re-checked this pull request!

Copy link

cla-bot bot commented Mar 4, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Isa.Inalcik.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@alaturqua alaturqua force-pushed the ii-add-kubernetes-podmonitor branch from 57dfbcb to f31a5c0 Compare March 4, 2024 12:03
@cla-bot cla-bot bot added the cla-signed label Mar 4, 2024
Comment on lines +444 to +445
# Requires the prometheus-operator to be installed in the cluster
# Requires jmx_exporter to be installed in the cluster
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how we should test this. Should there be a separate job in https://github.com/trinodb/charts/blob/main/.github/workflows/ci-cd.yaml, that would install these requirements? If we won't be testing this, I don't think it should be included in the chart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants