Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configmap checksum on deployments #127

Merged
merged 3 commits into from May 23, 2024

Conversation

DinGo4DEV
Copy link
Member

Add configmap checksum for automatically roll deployments on coordinator and worker:

  • depolyment-coordinator : configmap-catalog.yaml & configmap-coordinator.yaml
  • deployment-worker : configmap-worker.yaml

Copy link

cla-bot bot commented Jan 24, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@DinGo4DEV DinGo4DEV marked this pull request as ready for review January 25, 2024 10:53
Copy link

cla-bot bot commented Jan 30, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@DinGo4DEV
Copy link
Member Author

Thanks for signing the CLA - @cla-bot check

@cla-bot cla-bot bot added the cla-signed label Feb 14, 2024
Copy link

cla-bot bot commented Feb 14, 2024

The cla-bot has been summoned, and re-checked this pull request!

@nineinchnick
Copy link
Member

@DinGo4DEV please rebase, I recently added some new tests and a test.sh script that executes them. Would you be interested in adding a new update test to make sure this is working as expected?

@DinGo4DEV DinGo4DEV force-pushed the automatically-roll-deployments branch from 2ddd97e to aede9fb Compare May 23, 2024 10:08
@nineinchnick nineinchnick merged commit 2d372b5 into trinodb:main May 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants