Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the pod starts, add host aliases to the /etc/hosts file #110

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gitlabsam
Copy link

@gitlabsam gitlabsam commented Nov 28, 2023

When trino needs to access multiple clusters, the hosts for external cluster interactions need to be added to the /etc/hosts file, otherwise the IP of domain name format may not be reachable. Therefore, I added this feature to add the specified host aliases to the /etc/hosts file when the pod starts.

Copy link

cla-bot bot commented Nov 28, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@gitlabsam gitlabsam marked this pull request as draft November 28, 2023 08:04
@gitlabsam gitlabsam closed this Nov 28, 2023
@gitlabsam gitlabsam reopened this Dec 3, 2023
@cla-bot cla-bot bot added the cla-signed label Dec 3, 2023
@gitlabsam gitlabsam marked this pull request as ready for review December 3, 2023 09:01
@nineinchnick
Copy link
Member

This seems to have a very specific use case. Can you add a test for this, similar to https://github.com/trinodb/charts/blob/main/charts/trino/templates/tests/test-connection.yaml, and configure it in https://github.com/trinodb/charts/blob/main/test-values.yaml?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants