Template the password secret name #109
Open
+18
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@huw0 can you rebase? |
huw0
force-pushed
the
template-name-in-password-secret
branch
2 times, most recently
from
68e96b4
to
393e329
Compare
huw0
force-pushed
the
template-name-in-password-secret
branch
from
393e329
to
249e329
Compare
|
@nineinchnick - now rebased. With the changes I made in #108 it made sense for the helper to also be renamed in this PR. I've tested with the following options which I think correctly preserve backwards compatibility. However it'd be worth confirming my assumptions :). The default name of the secret is now - chartName-file-authentication. |
This was referenced May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title