TEST-30 #329
Open
TEST-30 #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed pica8 prompt. bin/run_cmds now works with Pica8 for output that does not page.
…-more' to show commands.
self-explanatory
Added comments and rearranged support.py
License updated to include attribution to Salesforce.com
Parser refactor
Fix hanging SSH connections to Cisco equipment
fix #144 + Also allow .tacacsrc passphrase to be stored in settings.py
NetDevice + Pager command support. Methods added: is_cisco_asa() disable_paging_cisco() NetACLInfo: Fixed to_cisco() to modify commands required for ASA. TODO: Add from_cisco_asa() method and use pyparsing to parse output.
NetDevices.is_cisco_asa() will now return True if Firewall _AND_ Cisco
- Also include new docs I forgot to commit.
Updates documentation for `check_access` to also mention that an explicit deny must exist in a policy for the suggested edits feature to work. Fixes #283.
- Fixed a typo in Arista command used for retrieving access-list names on interfaces. - Update the IOS-like interface parser to support `ip address negotiated` - Also fixed a typo in development docs.
- New setting: DEFAULT_ADMIN_STATUS which defaults to "PRODUCTION" - All new NetDevice objects will receive adminStatus="PRODUCTION" if the field is not provided - Clarified documentation for minium required fields to include adminStatus. - Added a section to NetDevices guide about additional fields (make, model) required to support certain platforms, such as the Cisco Nexus. - Removed deprecated documentation for NETDEVICES_FILE and NETDEVICES_FORMAT (these were deprecated in Trigger 1.3) - Moved the sample configs from `conf` at the project root to `configs` and retconned all the documentation to reference it.
#289) * changed gnng to use prettytable (PTable https://pypi.python.org/pypi/PTable/0.9.0) * changed prettytable import, added some ptable options, deleted extra space before x.strip() * added an empty line after output_table gets printed * added comment in changelog, added PTable as a requirement for trigger * deleted shitty windows ^M line endings
- Greatly simplified batch execution. All calls to `.run_commnds()` now run in their own SSH channel. - We might have some thread-safety issues related to NetDevice object prompt_patterns, startup_commands, and some other stuff related to `proto.device`. - Potential gotchas have been commented.
```
with dev as session:
r = session.run_commands(['show users'])
print r.results[0]
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TEST-30