Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #9

Open
wants to merge 1 commit into
base: backend-starter
Choose a base branch
from

Conversation

jamesjefferies
Copy link

Version 7 of pg wouldn't connect to latest postgres databases. Took me a long time to work out what was going wrong, before realising that the dependencies were quite out of date. These updates should all work fine.

Version 7 of pg wouldn't connect to latest postgres databases
@svanteschubert
Copy link

Incidentally, I started the last week-end myself to update the old GitHub version to current Node 12 LTS and aiming to use PostgreSQL 12. The idea is to pull the versions to the state of the art versions for newcomers.
I am not finished yet to share, but I am happy to exchange some insights, yet.

Some general comments on potential improvements/fixes:
I assume that as Patrick is referring in the README.md - which is far often been seen - to MIT license, the root license file and the package.json should be:
"license": "MIT",

The blog example would be far easier for newcomers to install if we would provide something basic Linux (e.g. Ubuntu) examples:
# 0.0 POSTRESQL:
sudo apt-get install postgresql-12
sudo apt-get install postgis
# 0.1 REDIS: easier than described in the referenced install guide
sudo apt-get install redis
# 0.2 Node.js: easier than described in the referenced install guide
sudo apt-get install nodejs
# psql -U postgres - does not work, therefore the below
sudo -u postgres psql

And last but not least, we should exchange 'patrick' in the SQL dump and the examples with 'gameadmin', so no one gets confused and everyone might keep the user.

Perhaps we should generate some docu equivalent to the blog posts in the GitHub Docs dir from markdown or similar.
I do very much like the way MongoDB is providing its documentation (guess using Sphinx)
https://docs.mongodb.com/manual/tutorial/install-mongodb-on-ubuntu/#install-mongodb-community-edition
They have a copy button to get the source example quickly in the clipboard and they got
"tabs" for different versions of doing the same thing (e.g. installation on Ubuntu, etc.) and so much more.
https://github.com/mongodb/docs
https://github.com/mongodb/docs-tools
Sure overkill, but hey, I might use this same tooling for the more commercial projects as well ;-)

What do you say, James? Or anyone, even Patrick, who seems to be quite busy these days ;-)

@jamesjefferies
Copy link
Author

jamesjefferies commented Jun 11, 2020

@svanteschubert I certainly think there's lots that could be updated. It's such a useful little tutorial that it would be a shame if people were put off because of things not working. Took me quite a while to get things sorted (the tileLayer url is out of date too for example) that it would be good to help others not make the same mistakes!

It all depends on whether @triestpa might have some time to review PRs etc and update the blog post

Copy link
Owner

@triestpa triestpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey folks, I'm sorry for the late reply here! This looks good to me, I'll make a not to update the tutorial with these changes soon too

@triestpa
Copy link
Owner

Hey folks, I'm sorry for the late reply here! This looks good to me, I'll make a not to update the tutorial with these changes soon too

If you have any other fixes locally (such as tileLayer url update) I'd be happy to merge them in and to update the tutorial text for it as well.

@minmaxdata
Copy link

Ive been going through this project. Its quite impressive! Im coming across out of date packages also. Will this pull request be merged?

@svanteschubert
Copy link

@triestpa Patrick, it seems you have forgotten to merge this one. :-)
I have not forgotten, but work projects steal my time, really love to start again on your project and certainly will come back, when I have something more to merge - x-mas time is always relaxed time to play around on projects like this. Thank you, Patrick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants