Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autodiscovery #675

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Autodiscovery #675

wants to merge 10 commits into from

Conversation

jnichols-git
Copy link
Member

Unreasonably Large Pull Request 2

  • Config makes more sense; reduced unneeded options
  • Backends are now properly instantiated and added to the ALB pool

Drafting as there's currently a bug preventing access to the instantiated backends. Working on a fix and will un-draft once ready.

@jnichols-git
Unified kubernetes client interface
f32d195 
Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
@jnichols-git
Add discovery + kubernetes configuration
7e44335 
Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
@jnichols-git
frame for clients, stubs for KubeClient
f2e73a9 
Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
@jnichols-git
Flesh out discovery process, start hooking up to alb
bfcc749 
Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
@jnichols-git
Finish populating targets
90f2331 
Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
@jnichols-git
config changes to stop things breaking, rearrangement of where things…
53b9887 
… get instantiated

Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
@jnichols-git
Register in routing instead of alb
7216c8b 
Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
@jnichols-git
Add default template capability
899d510 
Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
@jnichols-git
fix nil check
6c00255 
Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
@coveralls
Copy link

coveralls commented Jun 1, 2023 •
edited

Pull Request Test Coverage Report for Build 5148034125

  • 122 of 208 (58.65%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 92.377%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/backends/alb/pool/health.go 3 4 75.0%
pkg/backends/alb/options/options.go 1 3 33.33%
pkg/backends/options/options.go 2 4 50.0%
pkg/kube/selector.go 12 14 85.71%
pkg/kube/client.go 0 14 0.0%
pkg/kube/resource.go 89 106 83.96%
pkg/routing/routing.go 4 52 7.69%
Totals Coverage Status
Change from base Build 5008571097: -0.4%
Covered Lines: 17292
Relevant Lines: 18719
💛 - Coveralls

@jnichols-git
Handle scheme and fix handling of path prefix
eda041b 
Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
@jnichols-git jnichols-git marked this pull request as ready for review June 1, 2023 19:15
@jnichols-git jnichols-git requested a review from jranson June 1, 2023 19:17
@jnichols-git jnichols-git mentioned this pull request Jun 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jranson jranson Awaiting requested review from jranson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jnichols-git @coveralls