Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node v10 to CI #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

chrisblossom
Copy link
Contributor

Add Node v10 to CI.

@coveralls
Copy link

coveralls commented May 7, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 849ce59 on chrisblossom:add-node-10 into 546361b on tribou:master.

@chrisblossom
Copy link
Contributor Author

Not sure why the test is failing on windows node 10. Might want to try forcing a rebuild.

@tribou
Copy link
Owner

tribou commented May 8, 2018

Build started
Fetching repository commit (52ecded)...OK
Total: 17 MB in 648 files
Running Install scripts
Install-Product node $env:nodejs_version
Uninstalling node 4.8.7 (x86)...
Installing node 10.0.0 (x86)...
npm run yarn
> jest-serializer-path@0.1.15 yarn C:\projects\jest-serializer-path
> npm run --silent yarn-bin -- install --prefer-offline
yarn install v1.6.0
(node:2800) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
node --version
v10.0.0
npm run test

> jest-serializer-path@0.1.15 test C:\projects\jest-serializer-path
> npm run --silent lint && npm run --silent test-jest

'eslint' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! jest-serializer-path@0.1.15 test: `npm run --silent lint && npm run --silent test-jest`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the jest-serializer-path@0.1.15 test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?
npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\appveyor\AppData\Roaming\npm-cache\_logs\2018-05-08T02_52_38_476Z-debug.log
Command exited with code 1

Strange that it's not injecting the node_modules/.bin/ into the PATH. Since it's passing in the Linux CircleCI build, I'm assuming that must be a Windows implementation bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants