More tests about capture of global or non global scalar variables in kernels #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows some discussions inside the SYCL committee about kernel language restrictions. https://gitlab.khronos.org/sycl/Specification/issues/168
keryell
changed the title
agozillon
reviewed
Jan 12, 2019
|
|
||
| // Would be 1 with host device | ||
| // Would be 0 with OpenCL device | ||
| BOOST_CHECK(global == 1); |
There was a problem hiding this comment.
Perhaps I am wrong and misunderstanding something, but should this test have some way to optionally BOOST_CHECK global is the relevant value for what the test is compiled for? As if compiled for a device the global value would be set to 0 and this test would always fail in that case. Or do we aim to have the behavior that global would be 1 in both cases for device and host execution?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some examples following some discussions inside the SYCL committee about kernel
language restrictions.
https://gitlab.khronos.org/sycl/Specification/issues/168