fix(mobile): icons in Modal #10637
Merged
fix(mobile): icons in Modal #10637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nodonisko
force-pushed
the
fix/modal-icons
branch
from
a1728c7
to
55d4047
Compare
PeKne
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is bug in Skia when Canvas disappear when used in Modal and app is suspended and resumed from background.
Check issue in Skia repo for more details: Shopify/react-native-skia#2135
This is only hotfix, we should remove it once it's fixed in Skia library.
Description
Related Issue
Resolve #10634
Screenshots: