T3T1: fix old frame flickering when rising backlight #3806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TychoVrahe
changed the title
|
cepetr
approved these changes
May 9, 2024
TychoVrahe
force-pushed
the
tychovrahe/ui-t3t1/fix_flicker
branch
from
ff58e57
to
8d13729
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the previous protection relied at bg_copy being finished, but after that, it takes some time for the panel to refresh and actually show the new data.
i am switching to time-based protection. We could also consider some more sophisticated approaches like measuring number of TE signals after copying the data, but it seems unnecessarily complicated.
To limit the impact, i am only adding the wait if the backlight value is going up - as this is where the risk is.