Improve VTRUST bits documentation and naming. #3741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkozlik
requested review from
hiviah and
TychoVrahe
and removed request for
prusnak and
hiviah
matejcik
reviewed
Apr 22, 2024
|
It's much better with the documentation (the whole C part could use more of it). |
TychoVrahe
approved these changes
May 17, 2024
andrewkozlik
force-pushed
the
andrewkozlik/vtrust
branch
from
22caf2d
to
2beada9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a recent code review I was getting lost in the bitwise complement logic that is used for vtrust flags. This PR should improve legibility by renaming the code constants to what I believe to be more intuitive names and by adding more documentation.
VTRUST_ALL->VTRUST_NO_WARNINGVTRUST_ALLno longer represents "ultimate trust". It represents the absence of any vendor screen warnings.VTRUST_RED- >VTRUST_NO_REDetc.When the corresponding bit is set, it represents that no red screen should be shown, etc.