-
-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sending ButtonRequests from rust #3714
Merged
Merged
+489
−234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmilata
force-pushed
the
mmilata/ui-t3t1-buttonrequest
branch
from
April 24, 2024 16:04
b75ce45
to
b815b58
Compare
|
mmilata
force-pushed
the
mmilata/ui-t3t1-buttonrequest
branch
4 times, most recently
from
April 30, 2024 08:32
45eaab0
to
0fe277a
Compare
mmilata
force-pushed
the
mmilata/ui-t3t1-buttonrequest
branch
from
May 20, 2024 00:34
0fe277a
to
4176496
Compare
|
mmilata
force-pushed
the
mmilata/ui-t3t1-buttonrequest
branch
from
May 20, 2024 12:27
68a0689
to
81f4244
Compare
mmilata
changed the title
WIP: sending ButtonRequests from rust
Sending ButtonRequests from rust
May 20, 2024
mmilata
added a commit
that referenced
this pull request
May 20, 2024
this is supposed to go into main via #3714
mmilata
added a commit
that referenced
this pull request
May 20, 2024
this is supposed to go into main via #3714
mmilata
added a commit
that referenced
this pull request
May 20, 2024
this is supposed to go into main via #3714
mmilata
added a commit
that referenced
this pull request
May 20, 2024
this is supposed to go into main via #3714
matejcik
approved these changes
May 22, 2024
Two small changes in a417c07:
|
mmilata
force-pushed
the
mmilata/ui-t3t1-buttonrequest
branch
from
May 22, 2024 21:38
a417c07
to
a472e7a
Compare
mmilata
added a commit
that referenced
this pull request
May 28, 2024
this is supposed to go into main via #3714
mmilata
force-pushed
the
mmilata/ui-t3t1-buttonrequest
branch
from
May 28, 2024 16:12
a472e7a
to
ef29380
Compare
mmilata
added
the
translations
Put this label on a PR to run tests in all languages
label
May 28, 2024
mmilata
force-pushed
the
mmilata/ui-t3t1-buttonrequest
branch
from
May 28, 2024 16:51
ef29380
to
1d84c1d
Compare
[no changelog]
mmilata
force-pushed
the
mmilata/ui-t3t1-buttonrequest
branch
from
May 28, 2024 20:09
1d84c1d
to
ba8f7aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this against
main
since we need to make sure it doesn't break any model. The UI diffs are non-empty as the reordering of the tasks makes it possible for tests to capture one more screen in some cases, this seems to be stable so far.Known limitations: