Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending ButtonRequests from rust #3714

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Apr 12, 2024

Opening this against main since we need to make sure it doesn't break any model. The UI diffs are non-empty as the reordering of the tasks makes it possible for tests to capture one more screen in some cases, this seems to be stable so far.

Known limitations:

  • type enum not generated from .proto
  • didn't figure out how to use yield like other handlers instead of await

Copy link

github-actions bot commented Apr 24, 2024

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T2B1 Safe 3 3280 test(screens) main(screens) 2724
T3T1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

Copy link

github-actions bot commented May 20, 2024

legacy UI changes device test(screens) main(screens)

@mmilata mmilata force-pushed the mmilata/ui-t3t1-buttonrequest branch from 68a0689 to 81f4244 Compare May 20, 2024 12:27
@mmilata mmilata changed the title WIP: sending ButtonRequests from rust Sending ButtonRequests from rust May 20, 2024
@mmilata mmilata marked this pull request as ready for review May 20, 2024 12:51
@mmilata mmilata removed the request for review from prusnak May 20, 2024 12:52
mmilata added a commit that referenced this pull request May 20, 2024
this is supposed to go into main via #3714
mmilata added a commit that referenced this pull request May 20, 2024
this is supposed to go into main via #3714
mmilata added a commit that referenced this pull request May 20, 2024
this is supposed to go into main via #3714
mmilata added a commit that referenced this pull request May 20, 2024
this is supposed to go into main via #3714
@mmilata mmilata added the T3T1 label May 21, 2024
@mmilata
Copy link
Member Author

mmilata commented May 22, 2024

Two small changes in a417c07:

  • remove unused constant
  • rename from_tstring to from_num since br_type is now TString instead of heapless::String

@mmilata mmilata force-pushed the mmilata/ui-t3t1-buttonrequest branch from a417c07 to a472e7a Compare May 22, 2024 21:38
mmilata added a commit that referenced this pull request May 28, 2024
this is supposed to go into main via #3714
@mmilata mmilata force-pushed the mmilata/ui-t3t1-buttonrequest branch from a472e7a to ef29380 Compare May 28, 2024 16:12
@mmilata mmilata added the translations Put this label on a PR to run tests in all languages label May 28, 2024
@mmilata mmilata force-pushed the mmilata/ui-t3t1-buttonrequest branch from ef29380 to 1d84c1d Compare May 28, 2024 16:51
@mmilata mmilata force-pushed the mmilata/ui-t3t1-buttonrequest branch from 1d84c1d to ba8f7aa Compare May 28, 2024 20:09
@mmilata mmilata merged commit 3efa0f6 into main May 28, 2024
106 of 109 checks passed
@mmilata mmilata deleted the mmilata/ui-t3t1-buttonrequest branch May 28, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T3T1 translations Put this label on a PR to run tests in all languages
Projects
Status: 🤝 Needs QA
Development

Successfully merging this pull request may close these issues.

None yet

2 participants