Restartable timers #3702
Open
Restartable timers #3702
+170
−158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: I again forgot to add a changelog (this time for what was #3633 which is an impactful change that could plausibly affect users) |
|
|
matejcik
force-pushed
the
matejcik/queue-overflow
branch
from
be8eb9c
to
6489e27
Compare
matejcik
requested review from
mmilata and
obrusvit
and removed request for
prusnak
How? |
|
see the changelog:
if I missed a refresh somewhere, someone will see it as bad screen response |
… are gone this juuust might fix unexplained freezes on hardware
This was necessary for hooking display.refresh() with the old UI toolkit. With the new one, we explicitly refresh the display after every paint, so implicit after-step refresh seems no longer necessary.
matejcik
force-pushed
the
matejcik/queue-overflow
branch
from
ba47f68
to
69b724b
Compare
mmilata
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes "Queue overflow" error in T2B1 click tests which happens if (a) your CPU is fast enough or (b) you improve performance of UI code too much (also supersedes #3363 which could not be merged due to the speed improvement triggering this problem)
Summary of problem
Every button click in some screens will fire off a new timer event. Previously, there was no way to unschedule those timer events, so if you sent events too fast, there would be too many timers and they would overflow the queue
Summary of solution
A same logical timer will now reuse its event if it is already scheduled.
The performance cost amortizes to zero -- you spend work upfront to unschedule the event, but you save work of processing an already scheduled event which will be ignored in the end.
This means that every button click will schedule the same timer over and over again, saving precious queue space.
Quality of life
Timeris now a nicer struct member in that the user doesn't need to manually manage theirOption<TimerToken>, and internally handles starting, stopping, and restarting.Other changes
fixes T2B1: Wrong behavior when auto-mover hits a wall #3692 519dc9fnow that we haveufmt, I re-didprintln!macros to work the same way as the real thing, and introduceduformat!macro that works a lot like the real thing. Use this in your UI code with abandon. d5e6651refactor ofIgnoreButtonDelaywhich was needlessly using timers, and also was confusingly mixed into the already confusing state machine of ButtonController 7f5401b(removed unrelated changes, a separate PR will follow)